Reviewed-by: Dylan Baker <[email protected]> On a related note, I have a series that seriously overhauls the summary code, including fixing the console/text summary, producing a column for each result. It does include changes, fixes, and regressions in all cases like this patch. I'm hoping to have that cleaned up and on the list today.
On a tangent, why are you parsing the output of this, it seems like the
CSV summary would be easier to pass to another script than this, which
is volatile.
Dylan
On Wed, Sep 09, 2015 at 12:28:21PM +0000, Tom Stellard wrote:
> The counts for changes, fixes, and regressions are now reported as zero
> when no changes are detect rather than being omitted from the output.
>
> This makes it easier for scripts to parse the output of piglit summary
> console, becuase now when there are no regressions piglit always
> outputs:
>
> regressions: 0
>
> Before when there where no regressions, piglit would either print no
> regression line or it would print 'regressions: 0'
> ---
> framework/summary.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/framework/summary.py b/framework/summary.py
> index 80cb181..e56c0f2 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -604,7 +604,10 @@ class Summary:
> " fixes: {fixes}\n"
> "regressions: {regressions}".format(
> **{k: len(v) for k, v in self.tests.iteritems()}))
> -
> + else:
> + print(" changes: 0\n"
> + " fixes: 0\n"
> + "regressions: 0")
> print(" total: {}".format(sum(self.totals.itervalues())))
>
> # Print the name of the test and the status from each test run
> --
> 2.0.4
>
> _______________________________________________
> Piglit mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: Digital signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
