On Tue, Sep 8, 2015 at 10:59 AM, Chad Versace <[email protected]> wrote:
> On Tue 08 Sep 2015, Dylan Baker wrote: > > This is extending an existing test, does it really need to be added? > > If I interpreted correctly the output of `grep > arb_texture_compression-invalid-formats tests/all.py`, then yes. > > Nanley, without adding your ASTC invalid format tests to all.py, do they > still get run during a full Piglit run? > > They do not get run. It turns out that this test doesn't cycle through every format it knows about, but instead requires passing in an argument specifying which format to test. I'll add this change to my v2. > > On Sep 8, 2015 09:50, "Chad Versace" <[email protected]> wrote: > > > > > On Tue 08 Sep 2015, Chad Versace wrote: > > > > On Fri 28 Aug 2015, Nanley Chery wrote: > > > > > From: Nanley Chery <[email protected]> > > > > > > > > > > ASTC formats are added to the list of formats that should not be > > > returned by the > > > > > COMPRESSED_TEXTURE_FORMATS query. > > > > > > > > > > Signed-off-by: Nanley Chery <[email protected]> > > > > > --- > > > > > .../spec/arb_texture_compression/invalid-formats.c | 51 > > > +++++++++++++++++++++- > > > > > 1 file changed, 50 insertions(+), 1 deletion(-) > > > > > > > > Patch 1 is > > > > Reviewed-by: Chad Versace <[email protected]> > > > > > > Oops. I retract the rb. You need to add the test to all.py. > > > _______________________________________________ > > > Piglit mailing list > > > [email protected] > > > http://lists.freedesktop.org/mailman/listinfo/piglit > > > >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
