On Tue, Sep 15, 2015 at 7:28 AM, Jan Vesely <[email protected]> wrote:
> On Thu, 2015-09-10 at 10:12 -0500, Aaron Watry wrote: > > The char/short return buffers were declared as ints. > > > > Signed-off-by: Aaron Watry <[email protected]> > > Reviewed-by: Jan Vesely <[email protected]> > For both patches. > > though, I agree with Serge that a spec reference would be nice. > PS: don't we need to test this for *_MAX too? I'd expect at least char and short to have the same problem. > > Jan > > > --- > > tests/cl/program/execute/int-definitions.cl | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/tests/cl/program/execute/int-definitions.cl > > b/tests/cl/program/execute/int-definitions.cl > > index 3d8ee63..a438fe4 100644 > > --- a/tests/cl/program/execute/int-definitions.cl > > +++ b/tests/cl/program/execute/int-definitions.cl > > @@ -12,12 +12,12 @@ global_size: 1 0 0 > > [test] > > name: Char Definitions > > kernel_name: test_char > > -arg_out: 0 buffer int[6] 8 127 -128 127 -128 255 > > +arg_out: 0 buffer char[6] 8 127 -128 127 -128 255 > > > > [test] > > name: Short Definitions > > kernel_name: test_short > > -arg_out: 0 buffer int[3] 32767 -32768 65535 > > +arg_out: 0 buffer short[3] 32767 -32768 65535 > > > > [test] > > name: Int Definitions > > @@ -32,7 +32,7 @@ arg_out: 0 buffer long[3] 9223372036854775807 \ > > 18446744073709551615 > > !*/ > > > > -kernel void test_char(global int* out) { > > +kernel void test_char(global char* out) { > > int i = 0; > > out[i++] = CHAR_BIT; > > out[i++] = CHAR_MAX; > > @@ -42,7 +42,7 @@ kernel void test_char(global int* out) { > > out[i++] = UCHAR_MAX; > > } > > > > -kernel void test_short(global int* out) { > > +kernel void test_short(global short* out) { > > int i = 0; > > out[i++] = SHRT_MAX; > > out[i++] = (SHRT_MIN - (short2)(0)).s0; >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
