On Thu, 2015-12-10 at 07:49 +0000, Jose Fonseca wrote: > Piglit build failed due to C99 usage. Roland already fixed it, but > in > fact it's fine to use most C99 -- the MSVC version we require > supports > most of it too. > > What I don't why this didn't cause a compilation failure for you?
GCC 5 switched to gnu11 as default. https://gcc.gnu.org/gcc-5/changes.html > > Has GCC switched to C99 as default recently? > > Eitherway, it's probably better to add -std=gnu99 in piglit's > CMakeLists.txt. There's no reason not to. > > Jose > > > -------- Forwarded Message -------- > > piglit-ubuntu64 - Build # 3377 - Failure: > > Log: > [...truncated 25 lines...] > + rm -rf publish > + cmake -H. -Bbuild -G Ninja > -C/var/lib/hudson/tools/lin64/Cache.cmake > -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=publish > -DOPENGL_egl_LIBRARY=-NOTFOUND -DEGL_FOUND=0 -DPIGLIT_USE_WAFFLE=ON > -DWaffle_INCLUDE_DIRS=/var/lib/hudson/jobs/waffle > -ubuntu64/lastSuccessful/archive/publish/include/waffle-1 > -DWaffle_LDFLAGS=/var/lib/hudson/jobs/waffle > -ubuntu64/lastSuccessful/archive/publish/lib/x86_64-linux > -gnu/libwaffle-1.so > -DWaffle_LIBRARIES=/var/lib/hudson/jobs/waffle > -ubuntu64/lastSuccessful/archive/publish/lib/x86_64-linux > -gnu/libwaffle-1.so > loading initial cache file /var/lib/hudson/tools/lin64/Cache.cmake > -- checking for module 'egl' > -- found egl, version 10.5.9 > -- Configuring done > -- Generating done > -- Build files have been written to: > /var/lib/hudson/jobs/piglit-ubuntu64/workspace/build > + ninja -C build > ninja: Entering directory `build' > [1/2] Building C object > target_api/gl/tests/shaders/CMakeFiles/shader_runner.dir/shader_runne > r.c.o > FAILED: /usr/bin/cc -DPIGLIT_HAS_EGL -DPIGLIT_HAS_GLX > -DPIGLIT_HAS_PNG > -DPIGLIT_HAS_POSIX_CLOCK_MONOTONIC > -DPIGLIT_HAS_POSIX_TIMER_NOTIFY_THREAD -DPIGLIT_HAS_PTHREADS > -DPIGLIT_HAS_WAYLAND -DPIGLIT_HAS_X11 -DPIGLIT_USE_OPENGL > -DPIGLIT_USE_WAFFLE -DWAFFLE_API_VERSION=0x0103 -D_GNU_SOURCE -Wall > -Werror=vla -Werror=pointer-arith -Werror=variadic-macros -O2 -g > -DNDEBUG -I/usr/include/libdrm -I../src -Itests/util -I../tests/util > -I/var/lib/hudson/tools/lin64/glext -I../tests/mesa/util -MMD -MT > target_api/gl/tests/shaders/CMakeFiles/shader_runner.dir/shader_runne > r.c.o > -MF > target_api/gl/tests/shaders/CMakeFiles/shader_runner.dir/shader_runne > r.c.o.d > -o > target_api/gl/tests/shaders/CMakeFiles/shader_runner.dir/shader_runne > r.c.o > -c ../tests/shaders/shader_runner.c > ../tests/shaders/shader_runner.c: In function ‘process_shader’: > ../tests/shaders/shader_runner.c:984:2: error: ‘for’ loop initial > declarations are only allowed in C99 or C11 mode > for (unsigned i = 0; i < num_shaders; i++) { > ^ > ../tests/shaders/shader_runner.c:984:2: note: use option -std=c99, > -std=gnu99, -std=c11 or -std=gnu11 to compile your code > ninja: build stopped: subcommand failed. > Build step 'Execute shell' marked build as failure > Skipped archiving because build is not successful > Email was triggered for: Failure - 1st > Trigger Failure - Any was overridden by another trigger and will not > send an email. > Trigger Failure - Still was overridden by another trigger and will > not > send an email. > Sending email for trigger: Failure - 1st > > > Changes: > Changes for Build #3377 > [timothy.arceri] shader_runner: Add basic SSO support to shader > runner > > [timothy.arceri] shader_runner: add support for setting uniform by > location > > [timothy.arceri] shader_runner: add support for setting > glActiveShaderProgram() > > [timothy.arceri] shader_runner: add SSO support for remaining shader > stages > > [timothy.arceri] arb_enhanced_layouts: test layout location on block > members > > > > > Check console output at > http://id-hudson.eng.vmware.com:8080/job/piglit-ubuntu64/3377/ to > view > the results. > > > _______________________________________________ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit