On Thu, Jan 21, 2016 at 3:33 PM, Nicolai Hähnle <[email protected]> wrote: > From: Nicolai Hähnle <[email protected]> > > --- > tests/util/piglit-util-gl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c > index bbc174d..61764fb 100644 > --- a/tests/util/piglit-util-gl.c > +++ b/tests/util/piglit-util-gl.c > @@ -909,14 +909,19 @@ piglit_num_components(GLenum base_format)
This is no longer about base formats, right? I don't think GL_GREEN/BLUE can be base formats (or GL_BGRA). I have a mild preference to renaming this to just "format". Not going to insist on it though. Either way, Reviewed-by: Ilia Mirkin <[email protected]> > case GL_INTENSITY: > case GL_LUMINANCE: > case GL_RED: > + case GL_GREEN: > + case GL_BLUE: > return 1; > case GL_DEPTH_STENCIL: > case GL_LUMINANCE_ALPHA: > case GL_RG: > return 2; > case GL_RGB: > + case GL_BGR: > return 3; > case GL_RGBA: > + case GL_BGRA: > + case GL_ABGR_EXT: > return 4; > default: > printf("Unknown num_components for %s\n", > -- > 2.5.0 > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
