On Wed, Jun 1, 2016 at 1:49 AM, Kenneth Graunke <[email protected]> wrote: > On Wednesday, June 1, 2016 1:34:42 AM PDT Ilia Mirkin wrote: >> Because strtol() truncates the the maximum value of "long", as does >> scanf apparently. This will make it impossible to test that a counter >> == -1 though, right? > > Yes, I suppose it would. But you can always do == 4294967295 instead, > and that seems pretty reasonable (if a bit inconvenient) considering > the GLSL type is "atomic_uint"...
Fair enough. For ssbo I made it read 0xfoo for those. And there's already a tests/spec/arb_compute_shader/execution/atomic-counter.shader_test:probe atomic counter 1 == 4294966784 So what you're doing seems reasonable. Reviewed-by: Ilia Mirkin <[email protected]> _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
