Quoting Andres Gomez (2016-06-13 09:32:17) > On Fri, 2016-06-10 at 16:42 -0700, Dylan Baker wrote: > > [snip] > > > > > I've had this plan to add additional helpers for generator writers > > for > > representing GLSL type information, and this seemed like the right > > time > > to add them. > > This looks very good. I'm also repeating some value arrays for testing > each type and, also, several conversion functions from hex to actual > values so maybe it would be worth to think also about adding this into > a module. > > [snip] > > > Andres, I saw your series that extends this generator. Do you think > > it's > > better to consider landing this first and rebase your series ontop of > > this, or land yours first and rebase this series? > > Let's land this first and I will rework my series. In any case, I will > split the biggest patch as for your comments there. > > -- > Br, > > Andres > >
I've changed to use 1 instead of None, and pushed to master. Thanks again for your review. Dylan
signature.asc
Description: signature
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
