On Sat, Sep 10, 2016 at 11:40 AM, Ilia Mirkin <[email protected]> wrote: > On Sat, Sep 10, 2016 at 11:32 AM, Rob Clark <[email protected]> wrote: >> Signed-off-by: Rob Clark <[email protected]> >> Reviewed-by: Eric Anholt <[email protected]> >> --- >> tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c >> b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c >> index c3225c3..8e87b25 100644 >> --- a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c >> +++ b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c >> @@ -407,7 +407,7 @@ piglit_drm_get_driver(void) >> if (drv.fd == -1) { >> drv.fd = open("/dev/dri/card0", O_RDWR); >> if (drv.fd == -1) { >> - fprintf(stderr, "error: failed to open >> /dev/dri/renderD128 and " >> + fprintf(stderr, "error: failed to open >> /dev/dri/renderD128 or " >> "/dev/dri/card0\n"); > > Is it or? Looks like and to me...
as mentioned on IRC, the point was to convey that either render or card node is required.. (although, for multi-gpu we probably should be using drmOpen() or something??) maybe "failed to open A and B (requires either)"? BR, -R >> goto fail; >> >> -- >> 2.7.4 >> >> _______________________________________________ >> Piglit mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
