On 16.09.2016 10:44, Alejandro Piñeiro wrote:
On 15/09/16 18:02, Nicolai Hähnle wrote:
From: Nicolai Hähnle <nicolai.haeh...@amd.com>

A bunch of additions to the ARB_query_buffer_object test:

1. test different result types (including 64 bit types)
2. compare the written result with equality to the result obtained by
   querying on the CPU
3. add an additional mode to catch cache invalidation problems
4. additional checks that no values are written when they shouldn't
5. proper extension checks for the different query types

Also, rename the binary for the test to fit the extension-testname pattern.
 tests/all.py                                       |   2 +-
 .../spec/arb_query_buffer_object/CMakeLists.gl.txt |   2 +-
 tests/spec/arb_query_buffer_object/qbo.c           | 297 +++++++++++++--------
 3 files changed, 186 insertions(+), 115 deletions(-)

diff --git a/tests/spec/arb_query_buffer_object/qbo.c 
index c00b534..5eef41c 100644
--- a/tests/spec/arb_query_buffer_object/qbo.c
+++ b/tests/spec/arb_query_buffer_object/qbo.c
@@ -34,101 +34,94 @@
 #include "piglit-util-gl.h"

        config.supports_gl_compat_version = 32;
        config.supports_gl_core_version = 32;
        config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE |


-#define BUFFER_OFFSET(i) ((GLint *)((unsigned char*)NULL + (i)))
+#define BUFFER_OFFSET(i) ((void *)(i))

Out of curiosity, this was really needed or it was just clean-up?

It's needed because the calls to the different glGetQueryObject*(...) variants raised warnings. void* coerces into all other pointer types without warning in C.

Acked-by: Alejandro Piñeiro <apinhe...@igalia.com>

Piglit mailing list

Reply via email to