On Mon, 2016-10-24 at 11:15 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > Section 4.3.8.2 (Output Layout Qualifiers) of the GLSL 1.50 spec > > says: > > > > "All geometry shader output layout declarations in a program must > > declare the > > same layout and same value for max_vertices." > > > > Signed-off-by: Andres Gomez <[email protected]> > > --- > > ...ut-declaration-consistent-with-prev-layout.geom | 37 > > ++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 tests/spec/glsl-1.50/compiler/layout-out- > > declaration-consistent-with-prev-layout.geom > > > We have a negative test for this: > > tests/spec/glsl-1.50/compiler/layout-only-one-out-declaration-per- > program-max-verts.geom > > It would probably be nice to have similair names maybe just: > > layout-only-one-out-declaration-per-program-max-verts2.geom
What about renaming the existent to: layout-only-one-out-declaration-per-program-max-verts-mismatch.geom And the new one to: layout-only-one-out-declaration-per-program-max-verts.geom That would be consistent with many existing and the rest of the newly added tests. > Otherwise: > > Reviewed-by: Timothy Arceri <[email protected]> Thanks for the review! -- Br, Andres _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
