On Thu, Mar 30, 2017 at 8:19 AM, Nicolai Hähnle <[email protected]> wrote: > On 30.03.2017 14:07, Ilia Mirkin wrote: >> >> Time could roll over... not sure what to do about that though. Maybe >> check if the top 2 bits are set in the old value and are unset in the >> new value, and hope that the counter precision > 2 bits? [It'd be >> unfortunate for CIs to get occasional failures in these tests...] > > > Shouldn't roll-over be covered by the cast to int followed by comparison > with 0?
Let's say start_time == 0xfffffffffffffff, late_time = 0. Perhaps I'm getting the math wrong here, but as far as I can see, that test will fail. -ilia _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
