Quoting Petri Latvala (2017-04-13 03:06:38)
> Commit 5e699e402a8b ("framework: rename core.checkDir to
> core.check_dir") missed one call to checkDir in summary/feature.
>
> Signed-off-by: Petri Latvala <[email protected]>
> ---
>
> Does this also need exception handling changes like was done in
> aaf55584a42d ("framework: core.checkDir raises PiglitException")?It would be better if it did, since PiglitException is supposed to be for cases that we know what went wrong, but have no way to fix it (or there are multiple valid ways), we should catch it and raise a PiglitFatalError. > > > framework/programs/summary.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/programs/summary.py b/framework/programs/summary.py > index e400d9a..d0c5704 100644 > --- a/framework/programs/summary.py > +++ b/framework/programs/summary.py > @@ -277,6 +277,6 @@ def feature(input_): > shutil.rmtree(args.summaryDir) > > # If the requested directory doesn't exist, create it or throw an error > - core.checkDir(args.summaryDir, not args.overwrite) > + core.check_dir(args.summaryDir, not args.overwrite) > > summary.feat(args.resultsFiles, args.summaryDir, args.featureFile) > -- > 2.9.3 > > _______________________________________________ > Piglit mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: signature
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
