You should fix the commit message. The subject should be shorter. Additional comments can be put in a longer description after the short summary line. See, e.g. https://www.mesa3d.org/submittingpatches.html for guidelines.
On Thu, Jun 8, 2017 at 5:32 PM, Sandra Koroniewska <[email protected]> wrote: > --- > tests/spec/gl-2.1/pbo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/spec/gl-2.1/pbo.c b/tests/spec/gl-2.1/pbo.c > index bb4c0352c..313afcc93 100644 > --- a/tests/spec/gl-2.1/pbo.c > +++ b/tests/spec/gl-2.1/pbo.c > @@ -353,7 +353,7 @@ test_pixel_map(void) > } > > for (i = 0; i < max; i++) { > - if (pbo_mem[i] != (255 - i)) { > + if (pbo_mem[i] != (max- i - 1)) { Parentheses shouldn't be needed. Also, please put a space between operators. > REPORT_FAILURE("get PixelMap failed"); > return PIGLIT_FAIL; > } Other than that, the patch looks good to me. _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
