I applied your patch and compiled it. There were compilation warnings about passing GLubyte * to strncmp() and strcmp() which expects char *.
I've fixed that, adjusted the formatting and wrapped the lines to 78 columns. See attachemnt. If it looks OK to you, Sanda, I'll push it.
-Brian On 08/04/2017 05:06 AM, sandra koroniewska wrote:
Hi, thanks for the answer. Then, can anyone review this please? It would be a shame if this was not pushed, because a lot of people spent their time to comment this patch and WGL_EXT_swap_control is in the extension string on Windows Nvidia, AMD and Intel drivers. Regards, Sandra On Wed, Jul 26, 2017 at 3:50 PM, Martin Peres <[email protected] <mailto:[email protected]>> wrote: On 26/07/17 15:58, sandra koroniewska wrote: Hello, is this patch ok now? Because it hasn't been pushed. Regards, Sandra It still did not get any Reviewed-by. I guess the summer vacation is affecting the piglit team. _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
>From 65f85d67464182cb317c13478aba0d1f8092dad8 Mon Sep 17 00:00:00 2001 From: Sandra Koroniewska <[email protected]> Date: Thu, 29 Jun 2017 02:21:00 -0600 Subject: [PATCH] gl30basic: add some extra suspected extension WGL_EXT_SWAP_CONTROL is added for historical reasons. Some additional clean-up by Brian Paul. Reviewed-by: Brian Paul <[email protected]> --- tests/general/gl30basic.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/general/gl30basic.c b/tests/general/gl30basic.c index 2207787..d9d8ab8 100644 --- a/tests/general/gl30basic.c +++ b/tests/general/gl30basic.c @@ -92,13 +92,15 @@ test_extension_list(void) /* check that extension strings are reasonable */ for (k = 0; k < num_ext; k++) { - const GLubyte *ext = glGetStringi(GL_EXTENSIONS, k); + const char *ext = (const char *) glGetStringi(GL_EXTENSIONS, k); if (0) - printf("Ext[%d] = %s\n", k, (char *) ext); - if (!ext || - ext[0] != 'G' || - ext[1] != 'L' || - ext[2] != '_') { + printf("Ext[%d] = %s\n", k, ext); + + /* In some drivers WGL_EXT_swap_control is in the extension string + * for historical reasons. + */ + if (!ext || (strncmp(ext, "GL_", 3) != 0 && + strcmp(ext, "WGL_EXT_swap_control") != 0)){ printf("%s: bad extension string [%d]: %s\n", Prog, k, ext); return PIGLIT_FAIL; } -- 1.9.1
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
