Brian Paul <bri...@vmware.com> writes: > The glean fbo test exercises rendering to 1D, 2D, 3D and cube images > attached to FBOs. For the 1D texture case, the rendering is done with > a line, rather than a polygon. Since the 1D image is one pixel high, > the slightest mis-rasterization of the line will cause it to be clipped > and the test to fail. > > Just fall through to the polygon drawing code to avoid that issue. > Less code too.
If you just remove the whole switch statement around the POLYGON drawing code, this would get my r-b. :) I like this. Test line rasterization only in something that's about lines -- they're tricky to test well, and we've had plenty of trouble with this draw call.
signature.asc
Description: PGP signature
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
