Series + the glsl 450 test are Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu>
On Fri, Aug 11, 2017 at 2:55 AM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > > > On 08/10/2017 07:04 PM, Ilia Mirkin wrote: >> >> And an identical test to make sure it's disallowed at earlier GLSL >> versions? I see no such test already. > > > I can do that yeah. > > >> >> On Thu, Aug 10, 2017 at 12:44 PM, Samuel Pitoiset >> <samuel.pitoi...@gmail.com> wrote: >>> >>> Cc: Ian Romanick <ian.d.roman...@intel.com> >>> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> >>> --- >>> .../compiler/extra-semilons-at-global-scope.frag | 17 >>> +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> create mode 100644 >>> tests/spec/glsl-4.60/compiler/extra-semilons-at-global-scope.frag >>> >>> diff --git >>> a/tests/spec/glsl-4.60/compiler/extra-semilons-at-global-scope.frag >>> b/tests/spec/glsl-4.60/compiler/extra-semilons-at-global-scope.frag >>> new file mode 100644 >>> index 000000000..9da6ade08 >>> --- /dev/null >>> +++ b/tests/spec/glsl-4.60/compiler/extra-semilons-at-global-scope.frag >>> @@ -0,0 +1,17 @@ >>> +// [config] >>> +// expect_result: pass >>> +// glsl_version: 4.60 >>> +// [end config] >>> + >>> +#version 460 >>> + >>> +// From the GLSL 4.60 spec, section 1.2.1 (Summary of Changes from >>> Revision 7 >>> +// of GLSL Version 4.50): >>> +// >>> +// "Private Bug 16070: Allow extra semi-colons at global scope" >>> + >>> +uniform int i;; >>> + >>> +void main() >>> +{ >>> +} >>> -- >>> 2.14.0 >>> >>> _______________________________________________ >>> Piglit mailing list >>> Piglit@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit