On 08/22/2017 06:45 AM, Timothy Arceri wrote:


On 11/08/17 01:22, Samuel Pitoiset wrote:
Signed-off-by: Samuel Pitoiset <[email protected]>
---
  tests/general/draw-pixels.c           |  2 ++
  tests/general/geterror-inside-begin.c |  2 ++
  tests/general/geterror-invalid-enum.c |  2 ++
  tests/general/masked-clear.c          |  1 +
  tests/general/roundmode-pixelstore.c  | 10 +++++++---
  tests/general/select.c                |  2 ++
  tests/general/tex-errors.c            |  2 ++
  tests/general/texunits.c              | 24 ++++++++++++++----------
  8 files changed, 32 insertions(+), 13 deletions(-)

diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c
index 65f512266..a6c06c4d9 100644
--- a/tests/general/draw-pixels.c
+++ b/tests/general/draw-pixels.c
@@ -57,6 +57,8 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
      config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DEPTH | PIGLIT_GL_VISUAL_STENCIL;
+    config.khr_no_error_support = PIGLIT_HAS_ERRORS;

I think you should just add a !piglit_khr_no_error to the is_format_type_mismatch(format, type) test rather than skipping the whole thing.

Yeah, thanks for the review. :)


With that 46-50 are:

Reviewed-by: Timothy Arceri <[email protected]>
_______________________________________________
Piglit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to