On Mon, Aug 28, 2017 at 4:58 PM, Vinson Lee <[email protected]> wrote: > On Sat, Jan 2, 2016 at 1:08 PM, Ilia Mirkin <[email protected]> wrote: >> Creates an array with 3 draws, the last of which is "bad", and makes >> sure that the "bad" one is never drawn. Parameter count is supplied from >> an earlier XFB draw to ensure that proper fencing occurs. >> >> Signed-off-by: Ilia Mirkin <[email protected]> >> --- > > This patch introduced two GCC build warnings. > > tf-count-arrays.c: In function ‘piglit_display’: > tf-count-arrays.c:197:4: warning: passing argument 2 of > ‘piglit_dispatch_glMultiDrawArraysIndirectCount’ makes pointer from > integer without a cast [-Wint-conversion] > (2 * 4 * 4), 4, 1, 0); > ^ > tf-count-arrays.c:197:4: note: expected ‘const void *’ but argument is > of type ‘int’ > > > tf-count-elements.c: In function ‘piglit_display’: > tf-count-elements.c:206:4: warning: passing argument 3 of > ‘piglit_dispatch_glMultiDrawElementsIndirectCount’ makes pointer from > integer without a cast [-Wint-conversion] > (2 * 5 * 4), 4, 1, 0); > ^ > tf-count-elements.c:206:4: note: expected ‘const void *’ but argument > is of type ‘int’
Odd... the argument should be a GLintptr, which is a ptrdiff_t. Oh, but it looks like it's been recently changed to const void *. So I don't think it's this patch that introduced the warning, but rather a patch to update gl.xml (which might also have been from me...) _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
