On Mon, 2017-08-28 at 15:15 -0700, Vinson Lee wrote: > On Wed, Jul 19, 2017 at 3:51 PM, Jan Vesely <[email protected]> wrote: > > v2: Fix warning in cl-api-get-mem-object-info > > v3: Filter permissible queue properties combinations > > Use and test clCreateCommandQueueWithProperties on OCL 2.0 > > > > Signed-off-by: Jan Vesely <[email protected]> > > --- > > > > I see few regressions with this patch on beignet(SKL) in generated > > clamp/mad_sat long16 tests. Forcing the clc version to 1.2 in those test > > fixes the regression so I believe it's beignet bug. > > No regressions on clover Turks and beignet(IVB). > > > > Jan > > > > This patch introduced this GCC warning. > > create-command-queue.c: In function ‘piglit_cl_test’: > create-command-queue.c:159:12: warning: cast from pointer to integer > of different size [-Wpointer-to-int-cast] > (unsigned int)mixed_command_queue_properties); > ^
thanks for noticing. the attached patch should fix the problem (and correctly report failed property). Jan > _______________________________________________ > Piglit mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/piglit
From 9324f9da7dabf59fe983d7b7eb346cdc33b10d89 Mon Sep 17 00:00:00 2001 From: Jan Vesely <[email protected]> Date: Mon, 28 Aug 2017 18:20:26 -0400 Subject: [Piglit][PATCH 1/1] cl: Fix error message value. Fixes: f6d4e22d8b8eef1fbf5c7a234f520ae013a3e0d5 ("cl: Add support for OCL 2.0") Signed-off-by: Jan Vesely <[email protected]> --- tests/cl/api/create-command-queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/api/create-command-queue.c b/tests/cl/api/create-command-queue.c index 3ada5af90..e409d5261 100644 --- a/tests/cl/api/create-command-queue.c +++ b/tests/cl/api/create-command-queue.c @@ -156,7 +156,7 @@ piglit_cl_test(const int argc, fprintf(stderr, "Failed (error code: %s): Create command queue using 0x%X as command queue properties.\n", piglit_cl_get_error_name(errNo), - (unsigned int)mixed_command_queue_properties); + (unsigned int)mixed_command_queue_properties[1]); piglit_merge_result(&result, PIGLIT_FAIL); } clReleaseCommandQueue(command_queue); -- 2.13.5
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
