I didn't look too closely at this, but it seems correct.
Acked-by: Dylan Baker <dy...@pnwbakers.com>

Quoting Andres Gomez (2018-02-13 05:31:42)
> After:
> https://github.com/KhronosGroup/VK-GL-CTS/commit/f06134c65f55a009bbe284d2b7c0e56dee0f70cd
> 
> The Khronos CTS runner added a new KHR-NoContext case list.
> 
> This new test profile will run this new subset.
> 
> Cc: Mark Janes <mark.a.ja...@intel.com>
> Cc: Dylan Baker <dylanx.c.ba...@intel.com>
> Cc: Juan A. Suarez Romero <jasua...@igalia.com>
> Signed-off-by: Andres Gomez <ago...@igalia.com>
> ---
>  tests/khr_noctx.py | 79 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 tests/khr_noctx.py
> 
> diff --git a/tests/khr_noctx.py b/tests/khr_noctx.py
> new file mode 100644
> index 000000000..4cba8130d
> --- /dev/null
> +++ b/tests/khr_noctx.py
> @@ -0,0 +1,79 @@
> +# Copyright (c) 2017 Intel Corporation
> +
> +# Permission is hereby granted, free of charge, to any person obtaining a 
> copy
> +# of this software and associated documentation files (the "Software"), to 
> deal
> +# in the Software without restriction, including without limitation the 
> rights
> +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> +# copies of the Software, and to permit persons to whom the Software is
> +# furnished to do so, subject to the following conditions:
> +
> +# The above copyright notice and this permission notice shall be included in
> +# all copies or substantial portions of the Software.
> +
> +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> FROM,
> +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN 
> THE
> +# SOFTWARE.
> +
> +"""Piglit integration for the now open sourced Khronos CTS tests being
> +developed at https://github.com/KhronosGroup/VK-GL-CTS
> +
> +By default this will run NoContext test cases. Those desiring to run
> +only a subset of them should consider using the -t or -x options to
> +include or exclude tests.
> +
> +For example:
> +./piglit run khr_noctx -c foo -t gl43 would run only gl43 tests
> +
> +This integration requires some configuration in piglit.conf, or the
> +use of environment variables.
> +
> +In piglit.conf one should set the following:
> +[khr_noctx]:bin -- Path to the glcts binary
> +[khr_noctx]:extra_args -- any extra arguments to be passed to cts
> +(optional)
> +
> +Alternatively (or in addition, since environment variables have
> +precedence), one could set:
> +PIGLIT_KHR_NOCTX_BIN -- environment equivalent of [khr_noctx]:bin
> +PIGLIT_KHR_NOCTX_EXTRA_ARGS -- environment equivalent of
> +[khr_noctx]:extra_args
> +
> +"""
> +
> +from __future__ import (
> +    absolute_import, division, print_function, unicode_literals
> +)
> +import itertools
> +
> +from framework.test import deqp
> +
> +__all__ = ['profile']
> +
> +_KHR_BIN = deqp.get_option('PIGLIT_KHR_NOCTX_BIN', ('khr_noctx', 'bin'),
> +                           required=True)
> +
> +_EXTRA_ARGS = deqp.get_option('PIGLIT_KHR_NOCTX_EXTRA_ARGS', ('khr_noctx', 
> 'extra_args'),
> +                              default='').split()
> +
> +
> +class DEQPKHRTest(deqp.DEQPBaseTest):
> +    deqp_bin = _KHR_BIN
> +
> +    @property
> +    def extra_args(self):
> +        return super(DEQPKHRTest, self).extra_args + \
> +            [x for x in _EXTRA_ARGS if not x.startswith('--deqp-case')]
> +
> +
> +# Add all of the suites by default, users can use filters to remove them.
> +profile = deqp.make_profile(  # pylint: disable=invalid-name
> +    itertools.chain(
> +        deqp.iter_deqp_test_cases(
> +            deqp.gen_caselist_txt(_KHR_BIN, 'KHR-NoContext-cases.txt',
> +                                  _EXTRA_ARGS)),
> +    ),
> +    DEQPKHRTest)
> -- 
> 2.15.1
> 

Attachment: signature.asc
Description: signature

_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to