Quoting Vinson Lee (2018-05-17 13:28:26) > This build error occurs with cmake 2.8.12. > /bin/sh: BYPRODUCTS: command not found > > BYPRODUCTS is not available until cmake 3.2. > https://cmake.org/cmake/help/v3.2/release/3.2.html > > Fixes: 2f02cf0d4c2d ("Generate xml for builtin profiles") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106370 > Signed-off-by: Vinson Lee <v...@freedesktop.org> > --- > CMakeLists.txt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 8c7d162..e56aafb 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -1,4 +1,4 @@ > -cmake_minimum_required(VERSION 2.8.5) > +cmake_minimum_required(VERSION 3.2) > > list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules") > > -- > 1.7.1 >
I could have sworn I replied to this already, sorry about that. This seems reasonable to me, and I was going to propose it myself. 3.2 is from 2015, and 3.11 is current, and requiring software that's ~3 years old seems fine for a test suite. Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Dylan
signature.asc
Description: signature
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit