Yes, I agree that having the query string parsed is be very useful.
There is some other logic in parse_variables() which we do not want, so
we would have to make sure that none of that has any side effects. I
would propose we explicitly call only the query decode and
flatten_headers().
Arne
On 09/15/16 18:21, Stephen R. van den Berg wrote:
> I'm currently implementing the Engine.IO (and possibly Socket.IO) protocol
> in Pike (bidirectional realtime communication with JavaScript clients).
>
> While doing so I noticed (to my dismay) that in WebSocket, I find the
> following code snippet:
>
> protected int parse_variables() {
> if (has_index(request_headers, "sec-websocket-key"))
> return 0;
> return ::parse_variables();
> }
>
> I.e. parse_variables() is skipped on real websocket connections.
> What would be the reason why this is being skipped?
> I need to parse the variables on the URL of the soon-to-be-upgraded
> websocket connection; so it would be more convenient if it was handled
> automatically.
>
