Author: jtauber
Date: Wed Oct 1 02:23:02 2008
New Revision: 176
Modified:
trunk/wiki/views.py
Log:
fixed incorrect return of an exception rather than a response and switched
to using Forbidden status code
Modified: trunk/wiki/views.py
==============================================================================
--- trunk/wiki/views.py (original)
+++ trunk/wiki/views.py Wed Oct 1 02:23:02 2008
@@ -7,7 +7,7 @@
from django.template import RequestContext
from django.core.urlresolvers import reverse
from django.http import (Http404, HttpResponseRedirect,
- HttpResponseNotAllowed, HttpResponse)
+ HttpResponseNotAllowed, HttpResponse,
HttpResponseForbidden)
from django.shortcuts import get_object_or_404, render_to_response
from django.views.generic.simple import redirect_to
from django.utils.translation import ugettext_lazy as _
@@ -145,7 +145,7 @@
allow_write = has_write_perm(request.user, group, is_member)
if not allow_read:
- return Http404() # @@@ Shouldn't it be forbidden or something?
+ return HttpResponseForbidden()
articles = articles.order_by('-created_at')
@@ -197,7 +197,7 @@
allow_read, allow_write = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
try:
article = article_qs.get(**article_args)
@@ -255,7 +255,7 @@
allow_read, allow_write = True
if not allow_write:
- return Http404() # @@@ Shouldn't it be forbidden or something?
+ return HttpResponseForbidden()
try:
article = article_qs.get(**article_args)
@@ -357,7 +357,7 @@
allow_read, allow_write = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
article = article_qs.get(**article_args)
@@ -402,7 +402,7 @@
allow_read, allow_write = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
article = get_object_or_404(article_qs, **article_args)
changes = article.changeset_set.filter(
@@ -450,7 +450,7 @@
allow_read, allow_write = True
if not (allow_read or allow_write):
- return Http404()
+ return HttpResponseForbidden()
article = get_object_or_404(article_qs, **article_args)
@@ -531,7 +531,7 @@
allow_read, allow_write = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
template_params = {'changes': changes_qs.order_by('-modified'),
'allow_write': allow_write}
@@ -571,7 +571,7 @@
allow_read = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
article = get_object_or_404(article_qs, **article_args)
@@ -611,7 +611,7 @@
allow_read = True
if not allow_read:
- return Http404()
+ return HttpResponseForbidden()
article = get_object_or_404(article_qs, **article_args)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"pinax-updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/pinax-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
