Hi,
Just a few comments based on the code.
* Tried rebasing it against current master, there seems to be some
conflicts in the curve code.
* The new cursors look really nice... but I'm slightly worried about
accessibility due to the size of them. I'm using bigger fonts/icons
nowadays to avoid straining my eyes, and those trimming/playhead cursors
look really minute. Is there anything we could do to have them scaled
somewhat ?
The comments from Jeff are important too. Looks good otherwise,
Edward
P.S. No, I'm not going blind :)
On Tue, 2010-05-18 at 22:59 +0200, David Giardi wrote:
> >>
> >> I also started implementing custom cursors.
> >> One is shown when hovering any curve. It is a smaller arrow with the
> >> operation symbol on the corner (like cursors used in GIMP). The actual
> >> graphic is black-and-white, maybe it would be good to redraw it using
> >> the DMZ style.
> >
> > Oh, that's awesome. We need some special ones for ripple and roll
> > editing as well.
> >>
> >> ------------------------------------------------------------------------------
> >> _______________________________________________
> >> Pitivi-pitivi mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi
> >
> >
> >
>
> Hi,
>
> I added cursors for the left an right trimming operations.Some people
> may find the chosen graphics a bit small.
> The playhead on the time ruler is represented by an arrow-shaped
> handle in addition to the red line.
>
> Timeline curve handles were also changed. By the way,I fixed a bug
> that caused 2 overlapping handles to appear as 3 when zoomed out. The
> grouped drawing operation caused all square borders to be rendered in
> one pass, giving the illusion of an extra square in some cases.
> The current style is a test, closer to the one used in Vegas.
> My idea is to have slightly rounded squares filled with a light gradient.
>
> You may get the branch here : http://github.com/davlink/pitivi
> All changes above are open for comments, of course.
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Pitivi-pitivi mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi
------------------------------------------------------------------------------
_______________________________________________
Pitivi-pitivi mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi
