Thanks - I fixed the serialization issues, but I think it is OK to leave the
rest as-is.
On Wednesday, May 27, 2009, at 09:36AM, "Sandro Martini"
<[email protected]> wrote:
>Hi to all,
>just one question on the "Code freeze" for the 1.2 release.
>
>This means that only a little bug fixing could be done, or anything is
>blocked until the release will be accepted ?
>
>All this because I've just redo an analysis with FindBugs (this time
>integrated in eclipse, and this new version is much better than
>previous ... i can group problems by class name, etc), and some little
>things have been revealed.
>What do you think on fixing them (maybe many of them are false
>positive and not bugs) ?
>
>If i can help, tell me.
>
>
>Some of them (for example those of core), but on my non-just-updated sources:
>
>Class pivot.collections.EnumSet defines non-transient non-serializable
>instance field setListeners
>pivot/io/Folder.java:42 pivot.io.Folder$FileNameComparator implements
>Comparator but not Serializable
>pivot/collections/adapter/ListAdapter.java:111
>pivot.collections.adapter.ListAdapter.remove(int, int) might ignore
>java.lang.IllegalAccessException
>pivot/io/FileList.java:31 pivot.io.FileList$FilePathComparator
>implements Comparator but not Serializable
>pivot/util/Version.java:97 Equals method for pivot.util.Version
>assumes the argument is of type Version
>pivot/util/Service.java:90 Possible null pointer dereference of providerClass
>Class pivot.io.Folder defines non-transient non-serializable instance
>field fileFilter
>
>for web:
>pivot/web/Query.java:550 Exception is caught when Exception is not thrown
>
>for wtk:
>pivot/wtk/ApplicationContext.java:1149
>pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of
>URLs, which can be a performance hog
>pivot/wtk/Border.java:79 Comparison of String parameter using == or !=
>etc ...
>
>
>Sorry but i'd like to have our 1.2 release solid as a rock.
>
>
>Thanks,
>Sandro
>
>
