Re: Some small things to fix

[Sandro Martini]

Hi,
this is the patch for the inner classes (trivial):

Index: test/org/apache/pivot/collections/test/MapListTest.java
===================================================================
--- test/org/apache/pivot/collections/test/MapListTest.java     (revision 
806566)
+++ test/org/apache/pivot/collections/test/MapListTest.java     (working copy)
@@ -143,7 +143,7 @@
         assertEquals(0, mapList.getLength());
     }

-    private class TestMapListListener implements
MapListListener<String, Integer> {
+    private static class TestMapListListener implements
MapListListener<String, Integer> {
         private MapList<String, Integer> mapList;
         private Map<String, Integer> previousSource;
         private int calls;
@@ -157,7 +157,7 @@
         }
     }

-    private class TestComparator implements Comparator<Pair<String, Integer>> {
+    private static class TestComparator implements
Comparator<Pair<String, Integer>> {
         @Override
         public int compare(Pair<String, Integer> o1, Pair<String,
Integer> o2) {
             return o1.key.compareTo(o2.key);



And this is that for the random:

Index: src/org/apache/pivot/wtk/ApplicationContext.java
===================================================================
--- src/org/apache/pivot/wtk/ApplicationContext.java    (revision 806566)
+++ src/org/apache/pivot/wtk/ApplicationContext.java    (working copy)
@@ -48,6 +48,7 @@
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.util.Iterator;
+import java.util.Random;
 import java.util.Timer;
 import java.util.TimerTask;

@@ -89,7 +90,10 @@
         private boolean paintPending = false;

         private boolean debugRepaint = false;
+
+        private Random random = null;

+
         private transient DropTargetListener dropTargetListener = new
DropTargetListener() {
             public void dragEnter(DropTargetDragEvent event) {
                 if (dragDescendant != null) {
@@ -267,6 +271,9 @@

             try {
                 debugRepaint =
Boolean.parseBoolean(System.getProperty("org.apache.pivot.wtk.debugRepaint"));
+                if (debugRepaint == true)
+                    random = new Random();
+
             } catch (SecurityException ex) {
                 // No-op
             }
@@ -378,8 +385,8 @@
                     }

                     if (debugRepaint) {
-                        graphics.setColor(new
java.awt.Color((int)(Math.random() * 256),
-                            (int)(Math.random() * 256),
(int)(Math.random() * 256), 75));
+                        graphics.setColor(new
java.awt.Color(random.nextInt(256),
+                            random.nextInt(256), random.nextInt(256), 75));
                         graphics.fillRect(0, 0, getWidth(), getHeight());
                     }
                 } catch (RuntimeException exception) {



If Ok i can commit, tell me.

Bye