Yeah, that's a better wording (haven't fully absorbed the Pivot class
hierarchy yet)

On Thu, Oct 8, 2009 at 19:22, Greg Brown <[email protected]> wrote:
> I just checked in some (very) minor code formatting updates - otherwise, it 
> looks great! It really makes a huge difference in forms.
>
> One question: The Javadoc for ConstrainedVisual#getBaseline() says:
>
> "The baseline relative to the origin of the parent container. -1 indicates 
> that no baseline exists."
>
> What does "container" refer to in this case? Constrained visuals don't have a 
> concept of "container" (at least, not in the same sense as a component has a 
> container). Would it be accurate to say:
>
> "The baseline relative to the origin of this visual, or <tt>-1</tt> if this 
> visual does not have a baseline."
>
> G
>
> On Thursday, October 08, 2009, at 12:37PM, "Noel Grandin" 
> <[email protected]> wrote:
>>Hi
>>
>>I finally found some time to finish up the baseline work (PIVOT-99).
>>
>>I have checked it in, along with a test file (BaselineTest) that
>>activates the debugging paint code, so it's easier to see where
>>problems are.
>>
>>Let me know if there is anything I need to fix/add/modify.
>>
>>Regards, Noel.
>>
>>
>

Reply via email to