Hi Greg,

> It didn't work for me when I tried to run it, so there may be some additional 
> issues to work out.
What problems gives it to you ?
I've just tried to copy by hand this jsp file to demos/www (before I
have copied all pivot trunk in a separate folder), then run ant clean
and ant deploy, and verify that this jsp (and version.jsp) is also
inside the pivot-demos.war, finally start a local Tomcat, deploy the
generated war, and tried to run it at:
http://localhost:8080/pivot-demos/kitchen_sink.jsp
All works in my environments ... someone other are you able to test, please ...


> Couple of comments:
>
> 1) The code might be cleaner if you use the properties of the request to
> generate the "codebase" and "href" attributes:
>
>    <%
>    String scheme = request.getScheme();
>    String serverName = request.getServerName();
>    int serverPort = request.getServerPort();
>    String contextPath = request.getContextPath();
>
>    String codebase = scheme + "://" + serverName + ":" + serverPort + 
> contextPath;
>    String href = request.getServletPath();
>    %>
It's more verbose but for me it's the same, Ok.

> 2) We might want to consider mapping the "jnlp" extension to the JSP servlet
> so we can just call this file "kitchen_sink.jnlp".
One question: changing the Application Server I could not be able to
run jsp pages (I could have no more Tomcat JSP classes available), it
is Ok ?
So I don't like too much this, but i can try to do the trick.


> 3) Using the signed versions of the JARs may allow you to set the custom
> color scheme.
Ok, I'll try, and this could also help with Copy/Paste operations.

> 4) I think a simple "(JNLP)" or "(Web Start)" link next to the existing link
> would be sufficient (no need to restructure the page).
Ok, so no Web Start Applet version, right ?

Thanks,
Sandro

Reply via email to