[ 
https://issues.apache.org/jira/browse/PIVOT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764046#action_12764046
 ] 

Dmitry Mamonov commented on PIVOT-324:
--------------------------------------

About warning,

    @SuppressWarnings("unchecked")
    public <T> T getValue(String name) {
        return (T)get(name);
    } 

yes, in HtmlUnit methods declared exactly same:

package com.gargoylesoftware.htmlunit.html;
....
public abstract class HtmlElement extends DomElement {
.....
    /**
     * Simulates clicking on this element, returning the page in the window 
that has the focus
     * after the element has been clicked. Note that the returned page may or 
may not be the same
     * as the original page, depending on the type of element being clicked, 
the presence of JavaScript
     * action listeners, etc.
     *
     * @param <P> the page type
     * @return the page that occupies this element's window after the element 
has been clicked
     * @exception IOException if an IO error occurs
     */
    @SuppressWarnings("unchecked")
    public <P extends Page> P click() throws IOException {
        return (P) click(false, false, false);
    }

> WTKXSerializer get method enhancement
> -------------------------------------
>
>                 Key: PIVOT-324
>                 URL: https://issues.apache.org/jira/browse/PIVOT-324
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-wtkx
>            Reporter: Dmitry Mamonov
>            Assignee: Greg Brown
>            Priority: Minor
>             Fix For: 1.4
>
>
> Method get() of class WTKXSerializer returns value of type Object, you see:
> http://incubator.apache.org/pivot/1.3/docs/api/org/apache/pivot/wtkx/WTKXSerializer.html#get(java.lang.String)
> As demostrated in documentation it cause code like this: 
> (http://incubator.apache.org/pivot/1.3/tutorials/push_buttons.html)
>   private PushButton pushButton = null;
>    ...
>   pushButton = (PushButton)wtkxSerializer.get("pushButton");
> In an alternative way, get() method may be declared as:
>   <T> T get(String key){
>      //implementation
>   }
> This way client code will be just:
>   pushButton = wtkxSerializer.get("pushButton");
> so the type-case will be implicit. This feature is widely used in HtmlUnit 
> framework and I find it quite neat.
> May be it coult be adopted to pivot project :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to