It was done intentionally because it makes sense for some components and not for others. For instance, padding wouldn't make sense for components like Slider, ScrollBar, ScrollPane (given the row and column header), MenuBar, Panel, FileBrowser, etc.
As for the type, it's Insets for all components except TerraCalendarSkin, where its meaning is "the padding around each day". While it *could* be made an Insets there, it would look very weird to have uneven padding around the days in the calendar. The only style which has been promoted to a base class thus far is 'backgroundPaint' (in ContainerSkin). Styles *can* be promoted to base classes, but it should be done very sparingly, since we want to make sure that the style really does make sense for all components of that base type. -T On Wed, Nov 18, 2009 at 6:58 AM, Noel Grandin <noelgran...@gmail.com> wrote: > Hi > > I notice that not all of the skin classes have padding (e.g. > TextAreaSkin) , > and that in some of the classes it's a single int value (e.g. > TerraCalendarButtonSkin), > while in most of the other classes it's an Inset value. > > Surely this is something that for consistency should be present in all > skin classes, and should always be an Inset? > > Perhaps it can get factored out into something higher-up? > > -- Noel. >
