Hi Todd, > showEllipsis would be a boolean style in LabelSkin. Creating a subclass just > to avoid an if statement seems a bit much :-) Yes, you have reason, but I was thinking at a simple way to avoid adding if and calculations (the current length of the generated string, when this has to be enabled, etc), so the current component could be not modified and keep the best performances without having to handle not-so-common cases ... And could be useful also for us to see (and to show) how to extend our components.
> The use case is valid - it's been a TODO in LabelSkin since its creation > (before the days of JIRA, which is why it's not in JIRA). It would only > come into play in layout(), since the preferred size of the label wouldn't > be affected by this style. Ok, so instead of a boolean you like the proposal of different values ? > I don't think I've ever seen a text area with an ellipsis, but I have seen it > used (very rarely) in text inputs. For text area I was thinking at a text area inside a table cell, but having the ability to show only some of its contents ... I had many times this situation doing by hand SELECT of DB Tables with fields containing long text descriptions and the resulting output if not the best (usually the row containing that data will by displayed with a monster height to fit all the text). But I agree that this is a corner case. > Up to you on whether to open a ticket. We have a lot of TODOs in code that > hark back to the pre-ASF days, and I don't really think we need to create > tickets for all of them (we've been knocking them off one by one - creating > tickets would yield a lot of spam). Ok, but you remember that I have very little memory, so could be useful for me as a reminder, so if there aren't objections I'd add it for the 1.5 Thanks, Sandro
