Sorry - what I meant was that you could maintain all of the item heights in the array list - you didn't need the separate "variableItemLastHeight". I didn't mean that you should use an actual array... :-)
On Nov 19, 2009, at 8:32 AM, Noel Grandin wrote: > Hi Greg > > Thanks for the review. > > Greg Brown wrote: >> Line 68: - Why not use an ArrayList for the variable item heights? Also, >> this member should be renamed to "itemHeights", and its declaration should >> be moved below editIndex (it is currently declared between >> variableItemHeight and checkboxPadding, which implies that it is a style). >> >> > Because I was using ArrayList, and you said to change it to an array in > the last review. > > Applied the rest of the formatting, renaming and moving suggestions. > > > -- Noel.
