On Wednesday 05 May 2010, Soeren Sandmann wrote: > Siarhei Siamashka <[email protected]> writes: > > In the end, 'pixman_image_fill_boxes' still contains a call to > > 'pixman_fill' (for performance reasons?). So 'pixman_fill' is not retired > > completely. And regarding flexibility, 'pixman_fill' still does not > > supports formats with less than one byte per pixel. This looks like a > > bug. > > Is it actually _buggy_? color_to_pixel() only returns TRUE if the > format is wider than a byte, so that is the only case where > pixman_fill() actually gets called. In the other cases it falls back > to composite.
OK, looks like it should work fine then :) But there is an implicit dependency between color_to_pixel() and pixman_fill(). Also it should be possible to extend pixman_fill() to support all the missing formats to make it more consistent. -- Best regards, Siarhei Siamashka _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
