On Friday 29 October 2010 14:50:59 Soeren Sandmann wrote: > Siarhei Siamashka <[email protected]> writes: > > Hi, > > > > Looks like the following commit breaks __thread support detection because > > of '#ifdef defined' and extra '#endif': > > http://cgit.freedesktop.org/pixman/commit/?id=3411f9399c3ab6d642f350ea8e4 > > c355f719d01d9 > > > > Should this stuff be fixed or reverted? > > Fixed, I guess.
Yes, fixing is surely better :) I was just a bit annoyed because I had doubts that it even worked on mingw32 in the first place. But now that I found the original patch submission, I see that this was not the case. Testing on ming32 to confirm that now we are going to be fine would be appreciated. -- Siarhei >From 3c2448183d6c1e9672cdd3937293c698a8ac4463 Mon Sep 17 00:00:00 2001 From: Siarhei Siamashka <[email protected]> Date: Sat, 30 Oct 2010 15:51:30 +0300 Subject: [PATCH] Fixed broken configure check for __thread support Somehow the patch from [1] was not applied correctly, fixing that. 1. http://lists.cairographics.org/archives/cairo/2010-September/020826.html --- configure.ac | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b80cc5f..8193898 100644 --- a/configure.ac +++ b/configure.ac @@ -652,10 +652,9 @@ support_for__thread=no AC_MSG_CHECKING(for __thread) AC_LINK_IFELSE([ -#ifdef defined __MINGW32__ && !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)) +#if defined(__MINGW32__) && !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)) #error This MinGW version has broken __thread support #endif -#endif #ifdef __OpenBSD__ #error OpenBSD has broken __thread support #endif -- 1.7.2.2 _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
