Andrea Canciani <[email protected]> writes: > I think that strstr might cause substrings to also disable unintended > backends. > This would already happen for "mmx" vs "arm-iwmmxt". > Is this intentional? > Although in this specific case, it might be ok, I believe that it > might lead to unexpected behavior as other backends are added. > >> >> Indeed, this is very useful. >> >> I often seen if (!disabled(envvar) && supported()) where the disabling >> check is first in the if-statement. That's the only suggestion I have. >> Otherwise, this looks like a good change. > > I agree that if the backend is disabled, we should avoid checking the support. > This way, we can use disable to ensure that the backend cannot break > the application status in any way (example: modify simd registers > without restoring them appropriately).
I agree with both comments. New patch to follow. Thanks, Soren _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
