Sure, I'll make necessary changes and resubmit patches. Thanks, Nemanja Lukic
-----Original Message----- From: Siarhei Siamashka [mailto:[email protected]] Sent: Saturday, June 30, 2012 8:28 PM To: Lukic, Nemanja Cc: [email protected] Subject: Re: [Pixman] MIPS bilinear fast paths (src_8888_8_8888, src_8888_8_0565, src_0565_8_x888, src_0565_8_0565, add_8888_8_8888). On Mon, Jun 25, 2012 at 10:08 PM, Nemanja Lukic <[email protected]> wrote: > Added optimizations for several bilinear fast paths: > - src_8888_8_8888 > - src_8888_8_0565 > - src_0565_8_x888 > - src_0565_8_0565 > - add_8888_8_8888 > Benchmark results (using tweaked version of the lowlevel-blt-bench which does > bilinear scaling using almost identity matrix) on Malta board (@1Ghz) are > included in the log message. > These routines still use old BILINEAR_INTERPOLATE_SINGLE_PIXEL macro which has > potential to be more efficient (as pointed out in previous code review). This > improvement will be part of the future MIPS bilinear fast-path commits. > Any comments to this patch are welcome. The MIPS DSP ASE performance patches are always welcome. Just the timing is a bit bad this time. Could you please update your patchset and make it compatible with http://lists.freedesktop.org/archives/pixman/2012-June/002085.html ? So that the assembly code respects the interpolation precision settings defined as BILINEAR_INTERPOLATION_BITS constant and "make check" tests pass when setting it to 7 and 8. Thanks. -- Best regards, Siarhei Siamashka _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
