If there are no other comments, I'll push this patch set in a day or two. Nemanja Lukic
-----Original Message----- From: Siarhei Siamashka [mailto:[email protected]] Sent: Thursday, April 18, 2013 12:22 AM To: Nemanja Lukic Cc: [email protected] Subject: Re: [Pixman] Several MIPS fast paths and bug fixes. On Mon, 15 Apr 2013 19:32:53 +0200 Nemanja Lukic <[email protected]> wrote: > Added several MIPS DSPr2 fast paths and bug fixes. > Per previous code review: > - Pixbuf/rpixbuf test cases added before actual commits that add those fast > paths. > - Testing of the pixbuf/rpixbuf is not build-time decision anymore. > Any comments to these patches are welcome. The patches look acceptable to me. Especially the bugfixes (if there are any real users of MIPS DSPr2 code, they would surely appreciate having their problems resolved). Søren already mentioned that pushing patches to git master is fine as long as enough time has passed to review them: http://lists.freedesktop.org/archives/pixman/2013-March/002679.html I believe that if something is really wrong with the patches, then people are more likely to complain really fast. If you did not get any feedback and are unsure if the patch was approved or just unnoticed, then you can send an additional reminder about it a day or two before pushing. -- Best regards, Siarhei Siamashka _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
