Hi Vincent, Patch I sent to you was not intended for pushing upstream :) It was just for check. Your patch LGTM, and it should be pushed on Pixman trunk.
Thanks, Nemanja Lukic -----Original Message----- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 11, 2014 11:34 AM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: pixman-0.32.6 fails to build on mips32r2 Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to this email. Please, check it. Thanks. On 09/11/2014 10:02 AM, Nemanja Lukic wrote: > Hi Vincent, > > Please take a look at attached fix. > This one should solve the problem, without duplicating LEAF_MIPS32R2 macro. > Trick is to use pre-processor on the right level. > > Please check on your side, > Nemanja Lukic > > -----Original Message----- > From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] > Sent: Thursday, September 4, 2014 1:51 PM > To: pixman@lists.freedesktop.org > Cc: nemanja.lu...@rt-rk.com > Subject: pixman-0.32.6 fails to build on mips32r2 > > Could you please have a look to this bug report? > > https://bugs.freedesktop.org/show_bug.cgi?id=83358 > > Thank you. > -- Vincent _______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman