On Wed, 8 Apr 2015 14:20:30 +0100
Ben Avison <[email protected]> wrote:
> A few violations of coding style were identified in code copied from here
> into affine-bench.
> ---
> pixman/pixman.c | 18 ++++++++++--------
> 1 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/pixman/pixman.c b/pixman/pixman.c
> index 9555cea..a07c577 100644
> --- a/pixman/pixman.c
> +++ b/pixman/pixman.c
> @@ -325,18 +325,20 @@ _pixman_compute_composite_region32 (pixman_region32_t *
> region,
> return TRUE;
> }
>
> -typedef struct
> +typedef struct box_48_16 box_48_16_t;
> +
> +struct box_48_16
> {
> - pixman_fixed_48_16_t x1;
> - pixman_fixed_48_16_t y1;
> - pixman_fixed_48_16_t x2;
> - pixman_fixed_48_16_t y2;
> -} box_48_16_t;
> + pixman_fixed_48_16_t x1;
> + pixman_fixed_48_16_t y1;
> + pixman_fixed_48_16_t x2;
> + pixman_fixed_48_16_t y2;
> +};
>
> static pixman_bool_t
> -compute_transformed_extents (pixman_transform_t *transform,
> +compute_transformed_extents (pixman_transform_t *transform,
> const pixman_box32_t *extents,
> - box_48_16_t *transformed)
> + box_48_16_t *transformed)
> {
> pixman_fixed_48_16_t tx1, ty1, tx2, ty2;
> pixman_fixed_t x1, y1, x2, y2;
Reviewed-by: Pekka Paalanen <[email protected]>
I'll push this on Friday unless anyone objects. I heard I should have
push access now. This is a nice small patch to test my pushing.
Thanks,
pq
_______________________________________________
Pixman mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pixman
