On Thu, 16 Apr 2015 16:50:05 +0100 "Ben Avison" <[email protected]> wrote:
> > When doing component alpha, use a mask format that has all the color > > channels instead of just a8. > > In case you're waiting for me... Yes, I expect you to review my patches, as I do yours, since there is no-one else actively replying. :-) > That first sentence doesn't qualify the fact that this is specific to > solid masks. Other than that, looks good to me. Not sure whether that > qualifies as a Reviewed-by or Acked-by, take your pick! Yup, I can fix that wording. If you read the code, understood what it does, and it looks correct to you, that's a Reviewed-by. Acked-by is more like for the idea without carefully looking at the code. Thanks, pq _______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
