On Tue, 2015-05-05 at 18:04 +0300, Siarhei Siamashka wrote: > Thanks. But this is not quite correct. For example, try the > following example with the GNU assembler: > > $ cat test.S > .if __FOOBAR__ > .foobar_specific_directive > .endif > > $ gcc test.S > test.S: Assembler messages: > test.S:1: Error: non-constant expression in ".if" statement > > As such, the ".if __ELF__" code will fail to compile on non-ELF systems.
Thanks! I completely missed that. > I would suggest to simply remove this ".if __ELF__" / "#ifdef __ELF__" > check altogether. There is probably no notable MIPS system using a > non-ELF object file format nowadays. And even if such a MIPS system > exists, its users will just get a more meaningful error message about > the unsupported ELF-specific ".hidden" directive, which would look > similar to: > > test.S:1: Error: unknown pseudo-op: `.foobar_specific_directive' OK that seems reasonable. I'll remove it. James
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman