>-----Original Message----- >From: Matt Turner [mailto:[email protected]] >Sent: Sunday, February 9, 2020 7:01 AM >To: Yin Shiyou >Cc: [email protected] >Subject: Re: [Pixman] [PATCH] pixman-combine: Fix wrong value of >RB_MASK_PLUS_ONE. > >On Mon, Feb 3, 2020 at 1:56 AM Yin Shiyou <[email protected]> wrote: >> >> --- >> pixman/pixman-combine32.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pixman/pixman-combine32.h b/pixman/pixman-combine32.h >> index cdd56a6..59bb247 100644 >> --- a/pixman/pixman-combine32.h >> +++ b/pixman/pixman-combine32.h >> @@ -12,7 +12,7 @@ >> #define RB_MASK 0xff00ff >> #define AG_MASK 0xff00ff00 >> #define RB_ONE_HALF 0x800080 >> -#define RB_MASK_PLUS_ONE 0x10000100 >> +#define RB_MASK_PLUS_ONE 0x1000100 > > >Thanks. The patch looks correct, but obviously nothing in the test >suite is failing. How did you discover this? Does this patch fix >something for you?
I just found this mistake while analyzing macro 'UN8_rb_ADD_UN8_rb' and functions called this macro. I can't verify this error with existing test suite, it all passed no matter Fix it or not. _______________________________________________ Pixman mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/pixman
