Hi Teus, I took another look and it seems like you have not yet addressed the comments I made previously:
1. The debian/README contains no useful content and should be updated with something useful or removed. 2. The override for the mbed library is not being used and should be removed (I: bibledit source: unused-override embedded-library), and instead the override should be applied to /usr/bin/bibledit, as that is what is causing lintian to complain (E: bibledit: embedded-library usr/bin/bibledit: mbedtls) 3. Lintian complains that about the size /usr/share in the new package (I: bibledit: arch-dep-package-has-big-usr-share 170116kB 95%). While this is only info-level, I think it should be addressed. Specifically, the best course of action would be to introduce an arch-indep bibledit-data package similar to the old bibledit-gtk-data package. Additionally, I would like to ask that you push a pristine-tar branch which is suitable for git-buildpackage. The tarball generated when I tried to build from the Alioth repository has a different MD5 than the tarball you uploaded to mentors. Let me know when you have addressed these items or if you need any assistance. Regards, -Roberto On Wed, Mar 22, 2017 at 03:06:53PM +0000, Teus Benschop wrote: > Hi Roberto, > Thank you for adding me as a developer to the project in Alioth. > It works well: I can pull from and push to the repository at > [1]scm.alioth.debian.org/git/pkg-crosswire/bibledit-gtk.git. > The repository has now been updated with the updated Bibledit code and > Debian packaging. > There is two tags that can be used for comparing the updated code and > packaging with the existing: > debian/5.0.107-1 > upstream/5.0.107 > Teus > On Tue, 21 Mar 2017 at 12:37 Roberto C. Sánchez <[2][email protected]> > wrote: > > OK. I have added you as a developer to the project in Alioth, which > should give you write permissions to the repositories. Please let me > know if you encounter any problems. > > Regards, > > -Roberto > > On Tue, Mar 21, 2017 at 11:32:16AM +0000, Teus Benschop wrote: > > Hi Roberto, > > My username on Alioth is: > > > > teus-guest > > > > Thank you for offering to grant me write access to the repository. > > > > Once the write access has been granted, I then plan to update the > > repository with the newest version. > > > > Then all the history will be in the same place. That is much > neater. > > > > Teus > > On Mon, Mar 20, 2017, 2:46 PM Roberto C. Sánchez > <[1][3][email protected]> > > wrote: > > > > On Fri, Feb 24, 2017 at 12:23:07PM +0000, Teus Benschop wrote: > > > Hi Roberto, > > > The bibledit package that was uploaded to > [1][2][4]mentors.debian.net > > had an > > > issue with a dependency on the external libmbedtls. It > caused a > > > segmentation fault shortly after the initial calls to that > library. > > I have > > > uploaded a new package with a fix for that issue. It is > available > > > > > > at > [2][3][5]https://mentors.debian.net/debian/pool/main/b/bibledit/bibledit_5.0.107-1.dsc. > > > The git repository > at [3][4][6]https://github.com/bibledit/debian was > > updated > > > too, and the newest tags are debian/5.0.107-1 and > > upstream/[4]5.0.107. > > > Sorry for any inconvenience this may cause to you. > > > Teus. > > > > One additional note: if you will provide your Alioth username, I > think I > > can grant you commit access on the bibledit-gtk.git repository in > the > > pkg-crosswire project. Then you will be able to push your work > there > > directly. > > > > Regards, > > > > -Roberto > > > > -- > > Roberto C. Sánchez > > [5][7]http://people.connexer.com/~roberto > > [6][8]http://www.connexer.com > > _______________________________________________ > > Pkg-crosswire-devel mailing list > > [7][9][email protected] > > > > [8][10]http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > > > > References > > > > Visible links > > 1. mailto:[11][email protected] > > 2. [12]http://mentors.debian.net/ > > 3. > > [13]https://mentors.debian.net/debian/pool/main/b/bibledit/bibledit_5.0.107-1.dsc > > 4. [14]https://github.com/bibledit/debian > > 5. [15]http://people.connexer.com/~roberto > > 6. [16]http://www.connexer.com/ > > 7. mailto:[17][email protected] > > 8. > > [18]http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > > > _______________________________________________ > > Pkg-crosswire-devel mailing list > > [19][email protected] > > > > [20]http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > > -- > Roberto C. Sánchez > [21]http://people.connexer.com/~roberto > [22]http://www.connexer.com > _______________________________________________ > Pkg-crosswire-devel mailing list > [23][email protected] > > [24]http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > > References > > Visible links > 1. http://scm.alioth.debian.org/git/pkg-crosswire/bibledit-gtk.git > 2. mailto:[email protected] > 3. mailto:[email protected] > 4. http://mentors.debian.net/ > 5. > https://mentors.debian.net/debian/pool/main/b/bibledit/bibledit_5.0.107-1.dsc > 6. https://github.com/bibledit/debian > 7. http://people.connexer.com/~roberto > 8. http://www.connexer.com/ > 9. mailto:[email protected] > 10. > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > 11. mailto:[email protected] > 12. http://mentors.debian.net/ > 13. > https://mentors.debian.net/debian/pool/main/b/bibledit/bibledit_5.0.107-1.dsc > 14. https://github.com/bibledit/debian > 15. http://people.connexer.com/~roberto > 16. http://www.connexer.com/ > 17. mailto:[email protected] > 18. > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > 19. mailto:[email protected] > 20. > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > 21. http://people.connexer.com/~roberto > 22. http://www.connexer.com/ > 23. mailto:[email protected] > 24. > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel > _______________________________________________ > Pkg-crosswire-devel mailing list > [email protected] > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel -- Roberto C. Sánchez
signature.asc
Description: Digital signature
_______________________________________________ Pkg-crosswire-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-crosswire-devel
