Author: adam-guest
Date: 2008-02-26 07:11:58 +0000 (Tue, 26 Feb 2008)
New Revision: 1056

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
  + Add detection for <<<, $(OS|MACH)TYPE, $HOST(TYPE|NAME), $EUID, 
    $DIRSTACK, $SECONDS and /dev/(tcp|udp) (Closes: #465386)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2008-02-25 22:44:29 UTC (rev 1055)
+++ trunk/debian/changelog      2008-02-26 07:11:58 UTC (rev 1056)
@@ -3,8 +3,8 @@
   [ Adam D. Barratt ]
   * checkbashisms:
     + Fix a false positive in the $(( test (Closes: #465364)
-    + Add detection for <<<, $(OS|MACH)TYPE, $HOST(TYPE|NAME), $EUID and
-      $DIRSTACK (Closes: #465386)
+    + Add detection for <<<, $(OS|MACH)TYPE, $HOST(TYPE|NAME), $EUID, 
+      $DIRSTACK, $SECONDS and /dev/(tcp|udp) (Closes: #465386)
     + Enhance heredoc detection to not trigger on <<<
   * Debbugs.pm: Add status()
   * tagpending:

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2008-02-25 22:44:29 UTC (rev 1055)
+++ trunk/scripts/checkbashisms.pl      2008-02-26 07:11:58 UTC (rev 1056)
@@ -136,6 +136,7 @@
                '(?:^|\s+)trap\s+["\']?.*["\']?\s+.*[1-9]' => q<trap with 
signal numbers>,
                '\[\[(?!:)' => q<alternative test command ([[ foo ]] should be 
[ foo ])>,
                '<<<'                       => q<\<\<\< here string>,
+               '/dev/(tcp|udp)'            => q</dev/(tcp|udp)>,
            );
 
            my %string_bashisms = (
@@ -151,6 +152,7 @@
                '\$HOST(TYPE|NAME)\b'       => q<$HOST(TYPE|NAME)>,
                '\$DIRSTACK\b'              => q<$DIRSTACK>,
                '\$EUID\b'                  => q<$EUID should be "id -u">,
+               '\$SECONDS\b'               => q<$SECONDS>,
            );
 
            if ($opt_echo) {



-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to