Your message dated Fri, 29 Feb 2008 23:03:30 -0000 (UTC)
with message-id <[EMAIL PROTECTED]>
and subject line Re: Bug#468669: devscripts: [debchange] Empty lines created
has caused the Debian Bug report #468669,
regarding devscripts: [debchange] Empty lines created
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
468669: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468669
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.17
Severity: normal
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Since today's upgrade to 2.10.17 debchange inserts an empty line
before the new " * " entry. From looking through the code this seems
related to the fix for #452806, i.e. the changed reading of the
changelog; if I chomp $CHANGES the empty lines disappear again:
# Open in anticipation....
unless ($opt_create) {
open S, $changelog_path or fatal "Cannot open existing $changelog_path:
$!";
# Read the first stanza from the changelog file
# We do this directly rather than reusing $changelog{'Changes'}
# so that we have the verbatim changes rather than a (albeit very
# slightly) reformatted version. See Debian bug #452806
while(<S>) {
last if /^ --/;
$CHANGES .= $_;
}
chomp $CHANGES;
# Reset file pointer
seek(S, 0, 0);
}
I'm not sure if this affects other parts but it least it works for
(explicit or implicit $opt_a and for dch $TEXT).
Cheers,
gregor, now going back to actually using dch again :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHyHaKOzKYnQDzz+QRAgElAKCYj7jEC5xsT/4qppgW1Gi7Iu0OFQCgy9VH
8qJkbi04eh33pSA7akQNEvc=
=bsSB
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Version: 2.10.18
Hi,
> Since today's upgrade to 2.10.17 debchange inserts an empty line
> before the new " * " entry. From looking through the code this seems
> related to the fix for #452806, i.e. the changed reading of the
> changelog; if I chomp $CHANGES the empty lines disappear again:
Mea culpa. I hoped I'd fixed that before anyone would notice. :-/
Your diagnosis is correct. I spotted the problem whilst fixing another
issue (in checkbashisms) earlier this morning and uploaded .18 which fixes
this issue (although less elegantly than your suggestion, as I'd not had
any coffee at that point :-)
Regards,
Adam
--- End Message ---
