Author: adam-guest
Date: 2008-03-03 21:00:00 +0000 (Mon, 03 Mar 2008)
New Revision: 1095

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
  + Add checks for suspend, caller, complete/compgen, declare/typeset,
    disown, builtin, set -[BHT], alias -p, unalias -a, local with
    options or an assigned value and $BASH(_*). Thanks to Raphael
    Geissert for the patch (Closes: #469050)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2008-03-03 19:36:30 UTC (rev 1094)
+++ trunk/debian/changelog      2008-03-03 21:00:00 UTC (rev 1095)
@@ -10,6 +10,10 @@
       skipped (Closes: #469023)
     + Clarify in the manpage that some issues detected by the script may
       be XSIisms etc rather than strictly bash-specific features
+    + Add checks for suspend, caller, complete/compgen, declare/typeset,
+      disown, builtin, set -[BHT], alias -p, unalias -a, local with
+      options or an assigned value and $BASH(_*). Thanks to Raphael
+      Geissert for the patch (Closes: #469050)
 
  -- Adam D. Barratt <[EMAIL PROTECTED]>  Sat, 01 Mar 2008 11:42:02 +0000
 

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2008-03-03 19:36:30 UTC (rev 1094)
+++ trunk/scripts/checkbashisms.pl      2008-03-03 21:00:00 UTC (rev 1095)
@@ -143,6 +143,19 @@
                '\[\[(?!:)' => q<alternative test command ([[ foo ]] should be 
[ foo ])>,
                '<<<'                       => q<\<\<\< here string>,
                '/dev/(tcp|udp)'            => q</dev/(tcp|udp)>,
+               '(?:^|\s+)suspend\s' =>        q<suspend>,
+               '(?:^|\s+)caller\s' =>         q<caller>,
+               '(?:^|\s+)complete\s' =>       q<complete>,
+               '(?:^|\s+)compgen\s' =>        q<compgen>,
+               '(?:^|\s+)declare\s' =>        q<declare>,
+               '(?:^|\s+)typeset\s' =>        q<typeset>,
+               '(?:^|\s+)disown\s' =>         q<disown>,
+               '(?:^|\s+)builtin\s' =>        q<builtin>,
+               '(?:^|\s+)set\s+-[BHT]+' =>    q<set -[BHT]>,
+               '(?:^|\s+)alias\s+-p' =>       q<alias -p>,
+               '(?:^|\s+)unalias\s+-a' =>     q<unalias -a>,
+               '(?:^|\s+)local\s+-[a-zA-Z]+' => q<local -opt>,
+               '(?:^|\s+)local\s+\w+=' =>     q<local foo=bar>,
            );
 
            my %string_bashisms = (
@@ -159,6 +172,7 @@
                '\$DIRSTACK\b'              => q<$DIRSTACK>,
                '\$EUID\b'                  => q<$EUID should be "id -u">,
                '\$SECONDS\b'               => q<$SECONDS>,
+               '\$BASH(_[A-Z]+)?\b'        => q<$BASH(_SOMETHING)>,
            );
 
            if ($opt_echo) {



-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to