Author: adam-guest
Date: 2008-03-12 22:49:08 +0000 (Wed, 12 Mar 2008)
New Revision: 1126

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
  + Modify the "read without variable" test to also catch options other
    than -r. Thanks Luca Capello (Closes #470696)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2008-03-11 21:36:01 UTC (rev 1125)
+++ trunk/debian/changelog      2008-03-12 22:49:08 UTC (rev 1126)
@@ -34,6 +34,8 @@
     + Fix an unescaped hyphen in the manpage
     + Add a check for function names containing characters other than
       alphanumerics and underscore
+    + Modify the "read without variable" test to also catch options other
+      than -r. Thanks Luca Capello (Closes #470696)
   * bts:
     + Allow the sendmail command to begin with a ~ (Closes: #469207)
     + Don't treat "userblah" as an alias for "users" in "select"

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2008-03-11 21:36:01 UTC (rev 1125)
+++ trunk/scripts/checkbashisms.pl      2008-03-12 22:49:08 UTC (rev 1126)
@@ -129,7 +129,7 @@
                '[^\\\]\{([^\s]+?,)+[^\\\}\s]+\}' =>
                                               q<brace expansion>,
                '(?:^|\s+)\w+\[\d+\]=' =>      q<bash arrays, H[0]>,
-               '(?:^|\s+)(read\s*(?:;|$))' => q<read without variable>,
+               '(?:^|\s+)(read\s*(-[^r])?(?:;|$))' => q<should be read [-r] 
variable>,
                '\$\(\([A-Za-z]' => q<cnt=$((cnt + 1)) does not work in dash>,
                '(?:^|\s+)echo\s+-[e]' =>      q<echo -e>,
                '(?:^|\s+)exec\s+-[acl]' =>    q<exec -c/-l/-a name>,



-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to