On Mon, 2008-03-17 at 19:44 -0600, Raphael Geissert wrote:
> Adam D. Barratt wrote:
> > I believe these are all fixed in SVN, with one exception - a false
> > positive function name in freehdl-libtool (and indeed ltmain.sh in
> > general) due to:
> >
> > && $echo "X$libobj" | grep '[]~#^*{};<>?"'"'"' &()|`$[]' \
> >
> > Any suggestions as to how to resolve that welcome :-) The only solution
> > I've come up with thus far is fudging the regex to allow &s, but I'd
> > rather have the false positives than do that. :-/
>
> Can't that be handled by the quotes-handling part of checkbashisms?
> I really haven't looked at that part of the code, but my guess is that it
> should be 'fairly trivial' to fix at that part rather than modifying the
> check's regex.
>
> The quotes parser should understand it as '[]~#^*{};<>?"', "'", '
> &()|`$[]'
Possibly. The current string removal effectively replaces '.*?' with ''
before checking "string bashisms" and ".*?" with "" before the remaining
checks. That ends up reducing to:
&& $echo "" | grep ''"'' &()|`$[]' \
At the moment, I'm happy that we seem to have got rid of that set of
false positives, although no doubt some more will be along soon. ;)
Adam
--
To unsubscribe, send mail to [EMAIL PROTECTED]
