(Replying to correct cloned BR for second issue.) On Monday 07 April 2008, Luk Claes wrote: > Frans Pop wrote: > > + Set urgency=high if NMU and no other urgency set > > > > This is the most questionable change as it invites abuse of urgency. > > Indeed, I was not aware that it was changed already only that discussion > was opened... This is reverted in the next upload.
Thx. > > + Set to NMU if packager is neither in Uploaders nor Maintainer > > > > This has already proven to be incorrect for me today in two cases. > > - Team maintained D-I packages are frequently uploaded by a team member > > who's not listed as Uploader, mostly in the case of pre-release > > uploads for translation updates. These uploads are not NMUs. > > They are as team maintainers who upload should be in Uploaders or change > the default if they really don't want to be in Uploaders AFAICS... Where is the policy rule that says they _must_ be listed in uploaders? The overhead of maintaining that for D-I would be huge for no benefit at all, especially as being listed in uploaders in no longer required for bugs being closed. We prefer to have the regular, primary maintainers listed in Uploaders and thus keep relatively usable QA pages for our team members. Other teams has chosen to include everybody and their ponies in Uploaders. Both are valid choices IMO. > > - I wanted to do a testbuild for a patch for wireless-tools and ran > > dch to increase the version number so I could later run debdiff to get > > the patch. As the intention is not to NMU the package, having that set > > in the changelog is just silly. > > No, it's not as you might accidently upload the package. Besides you're > changing things in the package as a non-maintainer, so it's a sane > default IMHO. IMO it is not as it introduces cruft in the changelog I have not asked for. The NMU line should only be added when one actually intends to _do_ and NMU. I have in the past included changelog changes in a bug I submitted if I considered having a correct changelog entry an important part of the patch. Now I can no longer do that as easily. Basically you are changing behavior here for everybody that only really benefits a relatively small group of people: those who frequently do NMUs. I think it should be up to them to change the default behavior through the ~/.devscripts file rather than requiring existing users to do so. As I hope to have demonstrated, having the NMU behavior is not so logical that making it the default is warranted. I forsee that the D-I team will see incorrect uploads (NMUs that should be regular uploads) because of this change and therefore request that the old behavior be made default. Cheers, FJP
signature.asc
Description: This is a digitally signed message part.
