Author: adam-guest
Date: 2008-05-06 22:53:24 +0000 (Tue, 06 May 2008)
New Revision: 1434
Modified:
trunk/debian/changelog
trunk/scripts/checkbashisms.pl
Log:
Update the check for "function" to more closely match lintian's (and
therefore be less prone to false positives)
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-05-05 18:48:16 UTC (rev 1433)
+++ trunk/debian/changelog 2008-05-06 22:53:24 UTC (rev 1434)
@@ -6,6 +6,8 @@
* checkbashisms:
+ Also match use of "SHELL=/bin/bash -e" when checking whether a makefile
explicitly uses bash
+ + Update the check for "function" to more closely match lintian's (and
+ therefore be less prone to false positives)
* cowpoke: New script to upload a Debian source package to a cowbuilder host
and build it, optionally also signing and uploading the result to an
incoming queue (Closes: #479274)
Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl 2008-05-05 18:48:16 UTC (rev 1433)
+++ trunk/scripts/checkbashisms.pl 2008-05-06 22:53:24 UTC (rev 1434)
@@ -370,7 +370,7 @@
sub init_hashes {
my $LEADIN = '(?:(^|[`&;(|{])\s*|(if|do|while)\s+)';
%bashisms = (
- '(?:^|\s+)function\s+\w+' => q<'function' is useless>,
+ '(?:^|\s+)function \w+\(\s*\)' => q<'function' is useless>,
$LEADIN . 'select\s+\w+' => q<'select' is not POSIX>,
$LEADIN . 'source\s+(?:\.\/|\/|\$)[^\s]+' =>
q<should be '.', not 'source'>,
--
To unsubscribe, send mail to [EMAIL PROTECTED]
